Revert "BLD: pin numpy to particular variant that is built for all our deps #17625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r deps (pandas-dev#17619)" This reverts commit 6930f27. closes pandas-dev#17620
jreback
changed the title
|
looks like this now builds correctly (with the reverted pin). though it does downgrade numpy/blas appropriately, so I guess conda-forge fixed the dep issue. |
Yes, but it only does downgrade the blas version, not numpy version, so that doesn't affect the ABI compatibility of pandas. So indeed the deps issue seems fixed by conda-forge (there should have been some package that lacked numpy 1.13 build forcing it to downgrade) Thanks for the follow-up! |
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
…r deps (pandas-dev#17619)" (pandas-dev#17625) This reverts commit 6930f27. closes pandas-dev#17620
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
…r deps (pandas-dev#17619)" (pandas-dev#17625) This reverts commit 6930f27. closes pandas-dev#17620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #17619
This reverts commit 6930f27.
closes #17620